-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a few issues from MFE Bugbash India sheet #690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vivek-harness
changed the title
Fixed a issues from MFE Bugbash India sheet
Fixed a few issues from MFE Bugbash India sheet
Jan 16, 2025
vivek-harness
force-pushed
the
16-jan-bugbash
branch
3 times, most recently
from
January 20, 2025 08:23
73d4e8e
to
6ddf4f3
Compare
praneshg239
approved these changes
Jan 20, 2025
vivek-harness
force-pushed
the
16-jan-bugbash
branch
from
January 21, 2025 18:44
6ddf4f3
to
822b9c0
Compare
✅ Deploy Preview for harness-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -25,7 +25,9 @@ function Breadcrumbs() { | |||
{isLast ? ( | |||
<Breadcrumb.Page>{breadcrumb(match.params)}</Breadcrumb.Page> | |||
) : ( | |||
<Breadcrumb.Link href={match.pathname}>{breadcrumb(match.params)}</Breadcrumb.Link> | |||
<Breadcrumb.Link asChild> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been fixed in #766.
vivek-harness
force-pushed
the
16-jan-bugbash
branch
from
January 23, 2025 16:08
822b9c0
to
7947a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.google.com/spreadsheets/d/1kaR5TYxFxE6esk2JxO5VJdPVPFWHtVW7efQ5ZdTK7Go/edit?pli=1&gid=472839805#gid=472839805
This PR fixes the following issues from the above sheet: