Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few issues from MFE Bugbash India sheet #690

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Conversation

vivek-harness
Copy link
Contributor

https://docs.google.com/spreadsheets/d/1kaR5TYxFxE6esk2JxO5VJdPVPFWHtVW7efQ5ZdTK7Go/edit?pli=1&gid=472839805#gid=472839805

This PR fixes the following issues from the above sheet:

  • Clicking on Repoisitories in breadcrumbs navigates to incorrect path
  • Change branch -> Click on "xx commits behind" -> 404 page
  • Commit details page throwing 404 when navigated from commits page
  • While using Light Theme, monaco editor highlights file changes in black background color
  • In Light theme, open pull request count is shown in white color, and hence it seems to not exist
  • MFE: PR compare - changes - diff view has black background in light theme
  • MFE : click on repo name in breadcrumb navigates to wrong path

@vivek-harness vivek-harness added the bug Something isn't working label Jan 16, 2025
@vivek-harness vivek-harness self-assigned this Jan 16, 2025
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 7947a9c
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/679269862cad600008c11e16
😎 Deploy Preview https://deploy-preview-690--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vivek-harness vivek-harness changed the title Fixed a issues from MFE Bugbash India sheet Fixed a few issues from MFE Bugbash India sheet Jan 16, 2025
@vivek-harness vivek-harness force-pushed the 16-jan-bugbash branch 3 times, most recently from 73d4e8e to 6ddf4f3 Compare January 20, 2025 08:23
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for harness-design ready!

Name Link
🔨 Latest commit 7947a9c
🔍 Latest deploy log https://app.netlify.com/sites/harness-design/deploys/6792698660130200083f51d8
😎 Deploy Preview https://deploy-preview-690--harness-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -25,7 +25,9 @@ function Breadcrumbs() {
{isLast ? (
<Breadcrumb.Page>{breadcrumb(match.params)}</Breadcrumb.Page>
) : (
<Breadcrumb.Link href={match.pathname}>{breadcrumb(match.params)}</Breadcrumb.Link>
<Breadcrumb.Link asChild>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed in #766.

@vivek-harness vivek-harness merged commit e7c21cd into main Jan 23, 2025
14 checks passed
@vivek-harness vivek-harness deleted the 16-jan-bugbash branch January 23, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants